Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase spacing between actionbar items #32650

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Increase spacing between actionbar items #32650

merged 1 commit into from
Aug 16, 2017

Conversation

Lixire
Copy link
Contributor

@Lixire Lixire commented Aug 16, 2017

Fix #32236 's spacing item

@Lixire Lixire added the quick-pick Quick-pick widget issues label Aug 16, 2017
@Lixire Lixire added this to the August 2017 milestone Aug 16, 2017
@Lixire Lixire requested a review from roblourens August 16, 2017 17:41
@mention-bot
Copy link

@Lixire, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @egamma to be potential reviewers.

roblourens
roblourens reviewed Aug 16, 2017
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this rule is very generic, it could apply to other trees and actionbars, even though it's in quickopen.css. Is it impacting anywhere else?

@Lixire
Copy link
Contributor Author

Lixire commented Aug 16, 2017

I don't think so. I looked through it again and it seems like the only thing using it is indeed quickopen items.

@roblourens roblourens merged commit ca86458 into master Aug 16, 2017
@Lixire Lixire deleted the amqi/actionbar-spacing branch August 18, 2017 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees
No one assigned
Labels
quick-pick Quick-pick widget issues
Projects
None yet
Milestone
August 2017
Development

Successfully merging this pull request may close these issues.

Polish Terminal Switcher
4 participants
@Lixire @mention-bot @roblourens @msftclas